[PATCH] D45938: Improves x86 interrupt error message on argument type error

Danila Malyutin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 23 10:31:19 PDT 2018


danilaml added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:2997
       report_fatal_error("X86 interrupts may take one or two arguments");
+    bool isArg2Legal = (Is64Bit && Ins[1].VT == MVT::i64) ||
+                       (!Is64Bit && Ins[1].VT == MVT::i32);
----------------
danilaml wrote:
> What if `Ins.size() == 1`?
Wouldn't it now always fail if `Ins.size() == 1` ?


Repository:
  rL LLVM

https://reviews.llvm.org/D45938





More information about the llvm-commits mailing list