[PATCH] D44890: Allow to integrate OrcJIT with JitEventListeners

[Andres Freund via Phabricator via llvm-commits]

anarazel added a comment.

Ping? @lhames unfortunately you're probably the only one to review this?



================
Comment at: include/llvm-c/ExecutionEngine.h:187
+
+LLVMJITEventListenerRef LLVMCreateGDBRegistrationListener(void);
+LLVMJITEventListenerRef LLVMCreateIntelJITEventListener(void);
----------------
Create is wrong for at least GDB which essentially is a singleton, but I don' tthink it's helpful to deviate from the underlying name.


================
Comment at: include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h:167
+      if (this->Parent.NotifyFreed)
+        ObjForNotify = std::move(PFC->Obj); // needed for callback
       PFC = nullptr;
----------------
This isn't pretty, but I don't quite see a good alternative. 


================
Comment at: lib/ExecutionEngine/Orc/OrcCBindingsStack.h:428
+    }
+  }
+
----------------
This ain't algorithmically efficient, but I can't see enough listeners being registered for that to matter.


Repository:
  rL LLVM

https://reviews.llvm.org/D44890