[PATCH] D45968: StackSlotColoring: Decide colors per stack ID

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: MatzeB, qcolombet.
Herald added subscribers: nhaehnle, wdng.

I thought I fixed this in r308673, but that fix was
very broken. The assumption that any frame index can be used
in place of another was more widespread than I realized.
Even when stack slot sharing was disabled, this was still
replacing frame index uses with a different ID with a different
stack slot.

      

Really fix this by doing the coloring per-stack ID, so all of
the coloring logically done in a separate namespace. This is a lot
simpler than trying to figure out how to change the color if
the stack ID is different.


https://reviews.llvm.org/D45968

Files:
  include/llvm/CodeGen/MachineFrameInfo.h
  lib/CodeGen/StackSlotColoring.cpp
  test/CodeGen/AMDGPU/sgpr-spill-wrong-stack-id.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45968.143568.patch
Type: text/x-patch
Size: 13249 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180423/9f0d32f8/attachment.bin>