[PATCH] D45883: AMDGPU/GlobalISel: Implement select() for 32-bit G_FPTOUI

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

One bikeshed, apart of that LGTM.



================
Comment at: test/CodeGen/AMDGPU/GlobalISel/inst-select-fptoui.mir:20-26
+    ; fptoui s
+    ; GCN: V_CVT_U32_F32_e64
+    %3:vgpr(s32) = G_FPTOUI %0
+
+    ; fptoui v
+    ; GCN: V_CVT_U32_F32_e64
+    %4:vgpr(s32) = G_FPTOUI %1
----------------
I personally find the check lines easy to miss when they're indented like that and would prefer them to start at column 0. Admittedly I haven't checked the style elsewhere in LLVM.


Repository:
  rL LLVM

https://reviews.llvm.org/D45883