[PATCH] D45864: [RISCV] Support .option rvc and norvc

[Sameer AbuAsal via Phabricator via llvm-commits]

sabuasal added inline comments.


================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVTargetStreamer.h:21
+
+  virtual void emitDirectiveOptionRVC();
+  virtual void emitDirectiveOptionNoRVC();
----------------
This should be pure virtual method that you only implement in your RISCVTsargetELFstreamer and your RISCVASMstreamer. Making it virtual causes extra entries for your vtable.

Look at MCStreamer.h line 62


Repository:
  rL LLVM

https://reviews.llvm.org/D45864