[PATCH] D41979: [bcanalyzer] Recognize more stream types

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

In https://reviews.llvm.org/D41979#1074569, @modocache wrote:

> Thanks, @JDevlieghere! I added two tests like the ones you described. Thankfully it doesn't crash because llvm-bcanalyzer verifies the bitcode invariant that input sizes be a multiple of 4.


Thanks, Brian!

In https://reviews.llvm.org/D41979#1074575, @modocache wrote:

> Strange, the revision appeared to have been "Accepted" by @JDevlieghere. I wonder why the message says it wasn't accepted...? Apologies in advance if I did something incorrectly when landing this.


If someone request changes, they have to explicitly accept for Phabricator to consider the whole diff as accepted. I think the UI could do a better job at showing this, because I've seen this confuse people on several occasions. Anyway, I'm sure there's nothing to worry about here since you had already addressed @davide's comments.


Repository:
  rL LLVM

https://reviews.llvm.org/D41979