[PATCH] D45024: [DebugInfo] Add DILabel metadata and intrinsic llvm.dbg.label.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: javed.absar.

Thanks! Two more comments inline, LGTM otherwise.



================
Comment at: lib/IR/Verifier.cpp:1094
+      AssertDI(Op && (isa<DILocalVariable>(Op) || isa<DILabel>(Op)),
+               "invalid local element", &N, Node, Op);
     }
----------------
Let's be specific: `"expected DILocalVariable or DILabel."`


================
Comment at: lib/IR/Verifier.cpp:4595
+  DISubprogram *LocSP = getSubprogram(Loc->getRawScope());
+  if (!LabelSP || !LocSP)
+    return; // Broken scope chains are checked elsewhere.
----------------
Comment should go above the line.


Repository:
  rL LLVM

https://reviews.llvm.org/D45024