[PATCH] D45902: Add "-z lazy" and "-z relro".

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 20 13:58:02 PDT 2018


tmsriram added inline comments.


================
Comment at: lld/ELF/Driver.cpp:762
       Args.hasFlag(OPT_warn_symbol_ordering, OPT_no_warn_symbol_ordering, true);
   Config->ZCombreloc = !hasZOption(Args, "nocombreloc");
   Config->ZExecstack = hasZOption(Args, "execstack");
----------------
>From man ld , Same here, "combreloc"


================
Comment at: lld/ELF/Driver.cpp:765
   Config->ZHazardplt = hasZOption(Args, "hazardplt");
   Config->ZNocopyreloc = hasZOption(Args, "nocopyreloc");
   Config->ZNodelete = hasZOption(Args, "nodelete");
----------------
This is probably ok or maybe needs "copyreloc". In general, should every option here be negatable?  


https://reviews.llvm.org/D45902





More information about the llvm-commits mailing list