[PATCH] D45899: TableGen: Add a --write-if-changed flag to tablegen directly instead of doing it in cmake.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 20 12:59:57 PDT 2018


thakis added inline comments.


================
Comment at: lib/TableGen/Main.cpp:113
+      MBOrErr.getError() || std::move(MBOrErr.get())->getBuffer() != Out.str();
+  if (!OutputChanged && WriteIfChanged)
+    return 0;
----------------
Not sure if we should even have a --write-if-changed flag instead of doing this unconditionally, since we always pass the flag.


https://reviews.llvm.org/D45899





More information about the llvm-commits mailing list