[PATCH] D45880: [AArch64][SVE] Enable DiagnosticPredicates for SVE LD1 instructions.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 20 08:21:42 PDT 2018


sdesmalen added inline comments.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:509
 
-  template <int Bits, int Scale> bool isSImmScaled() const {
+  template <int Scale> bool isMemoryIndexSImm7() const {
+    return (bool) isSImmScaled<7, 4>();
----------------
fhahn wrote:
> Do we need this change for the patch?
This keeps the diagnostic behaviour the same for instructions that use MemoryIndexSImm7. The intention of this patch is to only change the diagnostics for SVE LD1.


https://reviews.llvm.org/D45880





More information about the llvm-commits mailing list