[PATCH] D44909: [DAGCombine] (float)((int) f) --> ftrunc (PR36617)

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 20 00:10:46 PDT 2018


hans added a comment.

In https://reviews.llvm.org/D44909#1072197, @spatel wrote:

> I see that patches were applied to the Chromium sources:
>  https://bugs.chromium.org/p/chromium/issues/detail?id=831145#c59
>
> Is it ok to re-commit this and see what else breaks? :)


Sounds okay to me. It would probably be good to add a release notes entry about this though, explaining what can break and showing how to use UBSan to check for it. I can easily imagine other code relying on the same pattern that V8 used.


Repository:
  rL LLVM

https://reviews.llvm.org/D44909





More information about the llvm-commits mailing list