[PATCH] D45801: COFF: Use (name, output characteristics) as a key when grouping input sections into output sections.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lld/COFF/Writer.cpp:458
+    // DATA | R | W.
+    if (Name == ".CRT")
+      OutChars = DATA | R;
----------------
smeenai wrote:
> If I'm reading this correctly link.exe only has this special case in 32-bit mode, but we're doing it for all architectures?
> 
> Also, when you say 32-bit, do you mean x86 specifically, or 32-bit ARM as well?
I can only reproduce it with `IMAGE_FILE_MACHINE_I386`. Do you think it's worth limiting based on machine?


https://reviews.llvm.org/D45801