[PATCH] D45832: [PDB] Output first section contribution for each module

[Zachary Turner via Phabricator via llvm-commits]

zturner created this revision.
zturner added reviewers: rnk, ruiu.
Herald added a subscriber: hiraditya.

One piece of the DBI stream is a list of module descriptors that include information about object file name, Stream index of the module's symbols, etc.

One piece of this descriptor that we have been leaving blank is the section contribution structure.  Although I'm not entirely sure what part of the debugger uses this (if any) it's important that we try to emit something correct to minimize the risk of strange hard-to-diagnose failures.

Comments in the refernece source indicate that this is supposed be the *first* section contribution for the module.  So, we simply emit a copy of the same structure that we emit for the section contribution list, but only for the first chunk for a given module.

Comparing LLD and link PDBs side by side, the results are now very similar.


https://reviews.llvm.org/D45832

Files:
  lld/COFF/PDB.cpp
  lld/test/COFF/pdb.test
  llvm/include/llvm/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.h
  llvm/lib/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45832.143143.patch
Type: text/x-patch
Size: 6948 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180419/17c6c2fb/attachment.bin>