[PATCH] D45798: LowerTypeTests: Propagate symver directives

Vlad Tsyrklevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 19 09:49:42 PDT 2018


vlad.tsyrklevich added inline comments.


================
Comment at: lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:361
+    Function *F = M.getFunction(Name);
+    if (!F || F->use_empty())
+      return;
----------------
@pcc This should probably be `F->hasAddressTaken()` instead of `F->use_empty()`, but I seem to recall that that would be actually be to restrictive for which functions we currently export--is that right?


Repository:
  rL LLVM

https://reviews.llvm.org/D45798





More information about the llvm-commits mailing list