[PATCH] D45688: [AArch64][AsmParser] Extend RegOp with integrated 'shift/extend'.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 19 07:19:18 PDT 2018


fhahn accepted this revision.
fhahn added a comment.

LGTM



================
Comment at: lib/Target/AArch64/AArch64RegisterInfo.td:174
   let RenderMethod = "addRegOperands";
+  let PredicateMethod = "isGPR64<AArch64::GPR64spRegClassID>";
   let ParserMethod = "tryParseGPR64sp0Operand";
----------------
This change seems unrelated to handling "integrated 'shift/extend'", but I do not think it is worth updating the diff just for that.


https://reviews.llvm.org/D45688





More information about the llvm-commits mailing list