[PATCH] D45811: [Unittests] Fix plugins test

Mikhail Maltsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 19 05:45:22 PDT 2018


miyuki created this revision.
miyuki added a reviewer: philip.pfaffe.
Herald added a subscriber: mgorny.

Currently the PluginsTests.LoadPlugin unit test is failing in
LLVM configurations that have LLVM_EXPORT_SYMBOLS_FOR_PLUGINS enabled
because the EnableABIBreakingChecks symbol is missing.

This patch fixes the issue by linking some additional libraries to the
test plugin if LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is enabled.


https://reviews.llvm.org/D45811

Files:
  unittests/Passes/CMakeLists.txt


Index: unittests/Passes/CMakeLists.txt
===================================================================
--- unittests/Passes/CMakeLists.txt
+++ unittests/Passes/CMakeLists.txt
@@ -16,7 +16,7 @@
     SUFFIX ".so"
     )
 
-  if (WIN32 OR CYGWIN)
+  if (WIN32 OR CYGWIN OR LLVM_EXPORT_SYMBOLS_FOR_PLUGINS)
     llvm_map_components_to_libnames(LLVM_DEPS ${LLVM_LINK_COMPONENTS})
     target_link_libraries(TestPlugin ${LLVM_DEPS})
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45811.143076.patch
Type: text/x-patch
Size: 442 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180419/098faa7b/attachment.bin>


More information about the llvm-commits mailing list