[PATCH] D45787: [llvm-exegesis] Fix PfmIssueCountersTable creation

Greg Bedwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 19 03:30:59 PDT 2018


gbedwell added a comment.

What's the more general plan for regression testing exegesis?  It looks like the issue with pfm failing to match counters was a regression introduced  by https://reviews.llvm.org/rL329675 due to the trailing commas. It would be nice to be able to have regression tests for this sort of thing, especially as it's under active development so the churn is likely to be quite high along with the risk of introducing regressions.  I know it gets complicated due to the libpfm dependency and the fact it's CPU specific, but it should still be a solvable problem.


Repository:
  rL LLVM

https://reviews.llvm.org/D45787





More information about the llvm-commits mailing list