[PATCH] D45721: [X86] Lowering PACK*S (pack with saturation) intrinsics to native IR (LLVM side)

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 18 14:55:49 PDT 2018


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:34717
+  if (VT.getVectorNumElements() * SVT.getSizeInBits() == 512 &&
+      (!Subtarget.hasAVX512() || !Subtarget.hasBWI()))
+    return false;
----------------
This should use !Subtarget.useBWIRegs() instead of hasBWI. And you can lose the hasAVX512 check. Someday I'm hoping to finish the zmm=low changes that sometimes make 512-bits illegal even though BWI is supported.


https://reviews.llvm.org/D45721





More information about the llvm-commits mailing list