[PATCH] D45754: [PM/LoopUnswitch] Detect irreducible control flow within loops and skip unswitching non-trivial edges.

Diego Caballero via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 18 12:26:37 PDT 2018


dcaballe added a comment.

Thanks, Florian!

> I looked and looked, even looked specifically in this area, and asked around, all without success at finding this. Now I'm sad I wasted time building a new one. Thanks for pointing it out.

Sorry to hear that. The same was about to happen to me but I just found that implementation in ShrinkWrap and generalized it. Glad to see it's useful somehow.

Thanks,
Diego



================
Comment at: llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp:1930
+  // loops "out of thin air". If we ever discover important use cases for doing
+  // this, we can add support to loop unswitch, but it is a lot of complexit
+  // for what seems little or no real world benifit.
----------------
typo -> complexity


Repository:
  rL LLVM

https://reviews.llvm.org/D45754





More information about the llvm-commits mailing list