[PATCH] D45655: [InstCombine][RFC] Canonicalize constant mask in masked merge mattern

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 18 08:10:01 PDT 2018


spatel added a comment.

See my comment in https://reviews.llvm.org/D45733. Sorry that I didn't get a chance to review/discuss this sooner.

I doubt the premise that this pattern should exist in the first place, so I suspect we don't want to add logic to transform it. But if it does exist, then and/and/or is the best canonical form for the IR - it's better for bit-tracking analysis and better for codegen.


Repository:
  rL LLVM

https://reviews.llvm.org/D45655





More information about the llvm-commits mailing list