[PATCH] D45454: Make __gcov_flush visible outside a shared library

Benoit Belley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 18 06:29:25 PDT 2018


belleyb added a comment.

@chh I had a chance to try out your proposed changes. It's not causing us any trouble. In fact, __gcov_flush() is not even used at all (at least in LLVM 5.0.1).. I can recompile llvm, compiler_rt and clang and re-run all the tests with __gcov_flush commented out! No problem.

I would suggest adding a bit more documentation to __gcov_flush(), thus describing what those "special cases" are...


https://reviews.llvm.org/D45454





More information about the llvm-commits mailing list