[PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

Erik Welander via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 17 17:55:21 PDT 2018


alur marked an inline comment as done.
alur added inline comments.


================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1773-1781
+static SectionType getSectionType(llvm::StringRef section_name) {
+  llvm::StringRef mapped_name;
+  if (section_name.startswith(".zdebug")) {
+    mapped_name = section_name.drop_front(2);
+  } else if (!section_name.startswith(".")) {
+    return eSectionTypeOther;
+  } else {
----------------
davide wrote:
> Thanks! This was exactly what I had in mind. Do you mind to split the NFC changes into a separate patch (that can be committed without review)? This will make this patch much easier to review.
Sure, attached it here.
{F5970155}


https://reviews.llvm.org/D45628





More information about the llvm-commits mailing list