[PATCH] D45728: [Polly] Allow arbitrary function calls for debugging purposes.

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 17 17:19:59 PDT 2018


I think it was actually not exactly the same but the early error block
support looked similar. It was replaced by the current error block
handling. What you want is different and seems useful.

With proper/sound I mean approximated dependences for the calls. That
effectivelly prevents optimizations and therefore is not what you want but
similar as it allows calls.

Cheers,
  Johannes

On Wed, Apr 18, 2018, 00:04 Michael Kruse <llvm at meinersbur.de> wrote:

> Could you give me a hint how to find that old revision?
>
> Do you remember why it was kicked out?
>
> Why do you think this version is not proper/sound?
>
> Michael
>
>
> 2018-04-17 14:22 GMT-05:00 Johannes Doerfert <johannesdoerfert at gmail.com>:
> > Funny thing is we actually had that functionality at some point years ago
> > but kicked it out. Maybe check the old code and if you want proper/sounds
> > support for those calls let me know I have a patch.
> >
> > On Tue, Apr 17, 2018, 20:02 Michael Kruse via Phabricator
> > <reviews at reviews.llvm.org> wrote:
> >>
> >> Meinersbur updated this revision to Diff 142813.
> >> Meinersbur added a comment.
> >>
> >> Use a ScopStmt's instruction list.
> >>
> >>
> >> https://reviews.llvm.org/D45728
> >>
> >> Files:
> >>   include/polly/Support/ScopHelper.h
> >>   lib/Analysis/ScopBuilder.cpp
> >>   lib/Analysis/ScopDetection.cpp
> >>   lib/Analysis/ScopInfo.cpp
> >>   lib/Support/ScopHelper.cpp
> >>   test/ScopInfo/debug_call.ll
> >>
> >> --
> >> You received this message because you are subscribed to the Google
> Groups
> >> "Polly Development" group.
> >> To unsubscribe from this group and stop receiving emails from it, send
> an
> >> email to polly-dev+unsubscribe at googlegroups.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Polly Development" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to polly-dev+unsubscribe at googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180418/2c73e398/attachment.html>


More information about the llvm-commits mailing list