[PATCH] D45727: Add tests for shrink wrapping and VLAs

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added a comment.

Sorry for not looking thoroughly at the test in the previous patch.



================
Comment at: test/CodeGen/AArch64/shrink-wrapping-vla.ll:17
+; RUN: llc -mtriple aarch64-linux %s -o - | FileCheck %s
+; REQUIRES: arm-registered-target
+
----------------
Hmm, I'm pretty sure this is not needed. Did you encounter any issues without this line? My understanding was that the test failed because it lived in `Generic` instead of the target directory.


================
Comment at: test/CodeGen/AArch64/shrink-wrapping-vla.ll:19
+
+define dso_local void @f(i32 %n, i32* nocapture %x) local_unnamed_addr #0 {
+entry:
----------------
Related to both tests: are these attributes actually needed? (the `#0`, `#1`)


https://reviews.llvm.org/D45727