[llvm] r330221 - LoadStoreVectorizer crashes due to unsized type

Stanislav Mekhanoshin via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 17 14:40:04 PDT 2018


Author: rampitec
Date: Tue Apr 17 14:40:04 2018
New Revision: 330221

URL: http://llvm.org/viewvc/llvm-project?rev=330221&view=rev
Log:
LoadStoreVectorizer crashes due to unsized type

When we skip bitcasts while looking for GEP in LoadSoreVectorizer
we should also verify that the type is sized otherwise we assert

Differential Revision: https://reviews.llvm.org/D45709

Added:
    llvm/trunk/test/CodeGen/X86/loadStore_vectorizer.ll
Modified:
    llvm/trunk/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp

Modified: llvm/trunk/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp?rev=330221&r1=330220&r2=330221&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp (original)
+++ llvm/trunk/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp Tue Apr 17 14:40:04 2018
@@ -284,8 +284,10 @@ GetElementPtrInst *Vectorizer::getSource
   // in pointee type size here. Currently it will not be vectorized.
   Value *SrcPtr = getLoadStorePointerOperand(Src);
   Value *SrcBase = SrcPtr->stripPointerCasts();
-  if (DL.getTypeStoreSize(SrcPtr->getType()->getPointerElementType()) ==
-      DL.getTypeStoreSize(SrcBase->getType()->getPointerElementType()))
+  Type *SrcPtrType = SrcPtr->getType()->getPointerElementType();
+  Type *SrcBaseType = SrcBase->getType()->getPointerElementType();
+  if (SrcPtrType->isSized() && SrcBaseType->isSized() &&
+      DL.getTypeStoreSize(SrcPtrType) == DL.getTypeStoreSize(SrcBaseType))
     SrcPtr = SrcBase;
   return dyn_cast<GetElementPtrInst>(SrcPtr);
 }

Added: llvm/trunk/test/CodeGen/X86/loadStore_vectorizer.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/loadStore_vectorizer.ll?rev=330221&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/X86/loadStore_vectorizer.ll (added)
+++ llvm/trunk/test/CodeGen/X86/loadStore_vectorizer.ll Tue Apr 17 14:40:04 2018
@@ -0,0 +1,16 @@
+; RUN: opt -load-store-vectorizer < %s -S | FileCheck %s
+
+%struct_render_pipeline_state = type opaque
+
+define fastcc void @main(%struct_render_pipeline_state addrspace(1)* %pso) unnamed_addr {
+; CHECK: load i16
+; CHECK: load i16
+entry:
+  %tmp = bitcast %struct_render_pipeline_state addrspace(1)* %pso to i16 addrspace(1)*
+  %tmp1 = load i16, i16 addrspace(1)* %tmp, align 2
+  %tmp2 = bitcast %struct_render_pipeline_state addrspace(1)* %pso to i8 addrspace(1)*
+  %sunkaddr51 = getelementptr i8, i8 addrspace(1)* %tmp2, i64 6
+  %tmp3 = bitcast i8 addrspace(1)* %sunkaddr51 to i16 addrspace(1)*
+  %tmp4 = load i16, i16 addrspace(1)* %tmp3, align 2
+  ret void
+}




More information about the llvm-commits mailing list