[PATCH] D45737: COFF: Merge .idata, .didat and .edata into .rdata by default.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc created this revision.
pcc added reviewers: ruiu, zturner.
Herald added a subscriber: javed.absar.
pcc added inline comments.


================
Comment at: lld/test/COFF/pdb-publics-import.test:39
     .rdata debug directory data chunks
-CHECK-NEXT:   SC[.rdata]  | mod = 1, 0002:0000, size = 28, data crc = 0, reloc crc = 0
+CHECK-NEXT:   SC[???]     | mod = 1, 0002:0000, size = 28, data crc = 0, reloc crc = 0
 CHECK-NEXT:                 IMAGE_SCN_CNT_INITIALIZED_DATA | IMAGE_SCN_MEM_READ
----------------
This is the only weird thing in the test updates.

@zturner I'm not sure if this is a pre-existing problem with our pdb emission?


This saves a little space and matches what link.exe does.

Tested using the chromium Windows trybots:
https://chromium-review.googlesource.com/c/chromium/src/+/1014784


https://reviews.llvm.org/D45737

Files:
  lld/COFF/Driver.cpp
  lld/test/COFF/arm64-relocs-imports.test
  lld/test/COFF/delayimports-armnt.yaml
  lld/test/COFF/delayimports.test
  lld/test/COFF/delayimports32.test
  lld/test/COFF/export-armnt.yaml
  lld/test/COFF/hello32.test
  lld/test/COFF/imports.test
  lld/test/COFF/pdb-publics-import.test
  lld/test/COFF/symtab.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45737.142828.patch
Type: text/x-patch
Size: 10778 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180417/0d91be8e/attachment.bin>