[PATCH] D45653: Enable sibling-call optimization for functions returning structs

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 17 08:09:10 PDT 2018


spatel added reviewers: qcolombet, Gerolf, escha, alexr.
spatel added a comment.

> Unfortunately when this if was added, no explanation was given why it is needed here. The corresponding test case is marked rdar://7726868, but I can not see what it is about.

I don't know enough about this to see the possible logic holes, but we should have someone with Radar access comment on the patch (adding some reviewer candidates).

As a preliminary clean-up, you might want to run update_llc_test_checks.py on this test file, so we can see the exact diffs in codegen.


Repository:
  rL LLVM

https://reviews.llvm.org/D45653





More information about the llvm-commits mailing list