[PATCH] D45572: [X86] Replace action Promote with Custom for operation ISD::SINT_TO_FP

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: test/CodeGen/X86/sitofp.ll:3
+
+target triple = "i386-unknown-linux-gnu"
+
----------------
vrybalov wrote:
> vrybalov wrote:
> > RKSimon wrote:
> > > This test needs improving - you need to add proper FileCheck testing, preferably use the update_llc_test_checks script to check all codegen and cleanup the actual test - I'm not convinced you need all this code to demonstrate the sitofp?
> > Main purpose of the test is to check llc doesn't hang on compilation. Now it hangs.
> Without "target triple = "i386-unknown-linux-gnu"" the test passes compilation now.
This should be sufficient to hit the bug

```
target triple = "i386-unknown-linux-gnu"

define double @foo(i16 %foo) #0 {
  %conv = zext i16 %foo to i32
  %conv1 = sitofp i32 %conv to double
  ret double %conv1
}

attributes #0 = { "use-soft-float"="true" }
```


Repository:
  rL LLVM

https://reviews.llvm.org/D45572