[PATCH] D45467: COFF: Friendlier undefined symbol errors.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 16 21:37:14 PDT 2018


zturner added a comment.

In https://reviews.llvm.org/D45467#1069519, @pcc wrote:

> In https://reviews.llvm.org/D45467#1069517, @zturner wrote:
>
> > Is there a particular reason to use a pointer? Inside the function it isn’t
> >  null checked so we’re already assuming non null.
>
>
> It's just the local convention, but I can change this one if you feel strongly.


Eh, stick with the convention.  Maybe in a follow up if I feel strongly enough I can throw up a patch to change the convention :)


https://reviews.llvm.org/D45467





More information about the llvm-commits mailing list