[PATCH] D45711: [WebAssembly] Add an assertion for an invalid CFG

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 16 19:22:18 PDT 2018


aheejin added a comment.

No, it was producing the correct answer. As long as `Header` was not empty, whether that part of the code was `Header` or `MBB` didn't affect the result of the code. That's what I kept saying for the whole day. Have a look at `MachineBasicBlock::findDebugLoc` <https://github.com/llvm-mirror/llvm/blob/a306456cafb95ea20023b82f407fefd2a9070213/lib/CodeGen/MachineBasicBlock.cpp#L1258-L1265>. So what I'm saying is I can't come up with a valid test case that was failing under the buggy code bug does not fail anymore now.


Repository:
  rL LLVM

https://reviews.llvm.org/D45711





More information about the llvm-commits mailing list