[PATCH] D45657: [Instruction, BasicBlock] Add is_none_of and skipInsts helper functions.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 16 16:25:23 PDT 2018


mattd added inline comments.


================
Comment at: include/llvm/IR/BasicBlock.h:185
 
+  /// \brief Return an iterator over the instructions in the block, skipping any
+  /// instances of any of the template arguments.
----------------
aprantl wrote:
> mattd wrote:
> > I realize \brief is used throughout this header, but I do not think that is necessary anymore, because the Doxygen.cfg has AutoBrief on.
> Yes, please avoid \brief.
> Bonus points for a separate NFC commit that removes \brief from the entire header :-)
> Bonus points for a separate NFC commit that removes \brief from the entire header :-)

Challenge accepted.


https://reviews.llvm.org/D45657





More information about the llvm-commits mailing list