[PATCH] D45418: [SimplifyLibcalls] Atoi, strtol replacements

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Transforms/Utils/SimplifyLibCalls.cpp:2329
+    case LibFunc_strtol:
+      return optimizeStrtol(CI, Builder);
     case LibFunc_printf:
----------------
xbolva00 wrote:
> efriedma wrote:
> > Can you also add cases here for atol, atoll, and strtoll?  (Your current implementations should just work.)
> Ok, I can add it.
> 
> Current tests in this patch are good enough or then should be new ones for atol, atoll, and strtoll too?
Maybe one test each to make sure we recognize the names, and a test to make sure 64-bit atoll actually allows inputs greater than 2**32; we don't need all the tests for each one given the code is the same.


https://reviews.llvm.org/D45418