[PATCH] D45593: [DebugInfo][OPT] Fixing a couple of DI duplication bugs of CloneModule

[Alberto Magni via Phabricator via llvm-commits]

alberto_magni added inline comments.


================
Comment at: llvm/trunk/lib/IR/DebugInfo.cpp:141
+    else
+      llvm_unreachable("unexpected imported entity type");
+  }
----------------
This commit is causing  failures in my SPEC2006 tests (xalancbmk among others) with -flto=thin and -g.
The unreachable in this line gets triggered. 

This is because the if-cascade above does not handle the case for DIGlobalVariable.
Probably the code that handles GlobalVariables at the top of the function needs to be replicated in one if-case here too.


Repository:
  rL LLVM

https://reviews.llvm.org/D45593