[PATCH] D45604: Support for multiarch runtimes layout

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

The overall goal makes sense to me, but I feel like this patch adds many CMake variables to accomplish it, which are only set from the Fuchsia CMake cache. I feel like it would be simpler to have one CMake flag that clang and the runtime libraries look at to decide if they want to use the old `libclang_rt.$arch.$lib` paths, or the new `clang/$version/$triple/lib/$lib` paths.

In other words, we should aim to make the CMake cache scripts as simple as possible. Most developers (so far as I know) don't use the cache scripts to configure their local builds. They directly invoke LLVM's CMake, usually with a shell script with their favorite options. Ideally, changing the runtime library layout this way would be adding a simple flag to that script, rather than requiring developers to switch to these cache scripts or duplicating the logic of the cache scripts.


Repository:
  rL LLVM

https://reviews.llvm.org/D45604