[llvm] r330073 - MachO: trap unreachable instructions

[Tim Northover via llvm-commits]

Hi James,

Thanks for looking.

On 14 Apr 2018, at 16:00, James Y Knight <jyknight at google.com> wrote:
> What does that have to do with binary file format?

The justification for using MachO mostly comes from ARM, where we have a few triples used for embedded targets that aren’t Darwin (which would seem like the natural choice). For example "thumbv7m-none-macho” (from “-arch armv7m”) and relatives. The MachO check is reasonably idiomatic for (“is it Apple”) there.

After that it was just consistency that led me to do the same on AArch64 & X86, but I’m pretty willing to change it to Darwin if you prefer.

Cheers.

Tim.