[PATCH] D45244: Add missing vtable anchors

[David Blaikie via llvm-commits]

On Sat, Apr 14, 2018 at 10:33 PM Weiming Zhao via Phabricator <
reviews at reviews.llvm.org> wrote:

> weimingz added a comment.
>
> In https://reviews.llvm.org/D45244#1064905, @dblaikie wrote:
>
> > Great - thanks for sticking with it, sorry for my dodgy explanations!
> >
> > If you're adding in anchors, are you using -Wweak-vtables to find them?
> If you're pushing through to make LLVM (& hopefully Clang/other LLVM
> subprojects) -Wweak-vtables clean, perhaps you can turn on the warning in
> the CMake config once it's clean so we don't regress this again? (it'd also
> be interesting to do some kind of analysis to see whether avoiding weak
> vtables is /actually/ worthwhile - like maybe making a
> temporary/local/non-committed change to change all the explicit anchors
> into inline functions (unanchoring them) & see if builds are much larger or
> longer, etc)
>
>
> I got linker error when my code tries to statically link against some LLVM
> libs (like libLLVMOrc). It's a good idea to turn on -Wweak-vtables to check
> if we miss other cases. I will try it. Thanks
>

Hmm, I'm confused - you mean without these changes you were getting link
errors due to vtable symbols for types with weak vtables? I'm not sure why
that would be - your code should've been built with its own weak vtable, in
that situation.

- Dave


>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D45244
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180416/e1dc5a9e/attachment.html>