[PATCH] D45661: Rename ObjectMemoryBuffer to SmallVectorMemoryBuffer; NFCI

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 15 19:53:06 PDT 2018


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Fix up a few comments & then it seems fine.



================
Comment at: include/llvm/Support/SmallVectorMemoryBuffer.h:1-2
-//===- ObjectMemoryBuffer.h - SmallVector-backed MemoryBuffrer  -*- C++ -*-===//
+//===- SmallVectorMemoryBuffer.h - SmallVector-backed MemoryBuffrer  -*- C++
+//-*-===//
 //
----------------
Please fix this comment so it still ends with "-*- C++ -*-==//" - maybe by removing the descriptive text, now that it's a bit redundant.


================
Comment at: include/llvm/Support/SmallVectorMemoryBuffer.h:46-48
+  /// \brief Construct a named SmallVectorMemoryBuffer from the given
+  /// SmallVector
   ///        r-value and StringRef.
----------------
Line wrapping (maybe just drop the indentation and put the "r-value and StringRef." at the end of the previous line.


Repository:
  rL LLVM

https://reviews.llvm.org/D45661





More information about the llvm-commits mailing list