[PATCH] D45420: [NFC] [LoopUtil] Moved RecurrenceDescriptor/LoopDescriptor from Transform/Utils/LoopUtils.* to Analysis tree

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 13 12:16:57 PDT 2018


hsaito added inline comments.


================
Comment at: lib/Transforms/Scalar/LICM.cpp:46
 #include "llvm/Analysis/MemorySSA.h"
+#include "llvm/Analysis/MustExecute.h"
 #include "llvm/Analysis/OptimizationRemarkEmitter.h"
----------------
rengolin wrote:
> Why these new includes?
Moved #include from .h to .cpp. Header file doesn't really need to #include. it  Forward declaration of class names are enough.  Just followed "#include as little as possible" when I tried to figure out which #includes are actually needed.


Repository:
  rL LLVM

https://reviews.llvm.org/D45420





More information about the llvm-commits mailing list