[PATCH] D43025: [tsan] Add support for linux/powerpc64 in buildgo.sh

Carlos Eduardo Seo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 13 09:31:57 PDT 2018


cseo added a comment.

In https://reviews.llvm.org/D43025#1067279, @dvyukov wrote:

> Looks good to me.
>  Do you have commit access, or you want me to commit it?


Could you please do it? I don't have commit access. Thanks!



================
Comment at: lib/tsan/go/buildgo.sh:59
+		SUFFIX="linux_amd64"
+		OSCFLAGS="-ffreestanding -Wno-unused-const-variable -Werror -Wno-unknown-warning-option"
+	fi
----------------
dvyukov wrote:
> If I am reading this correctly, amd64 will not have -fPIC because this overrides whole OSCFLAGS rather than append to them. Do we need something like:
> ```
> OSCFLAGS="$OSCFLAGS -ffreestanding -Wno-unused-const-variable -Werror -Wno-unknown-warning-option"
> ```
> ?
Oops... sorry about that.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43025





More information about the llvm-commits mailing list