[PATCH] D45618: [AArch64][SVE] Asm: Support for contiguous LD1 (scalar+imm) load instructions

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 13 06:40:05 PDT 2018


sdesmalen added a comment.

In https://reviews.llvm.org/D45618#1067038, @rengolin wrote:

> LGTM, thanks!


Thanks for the quick review!



================
Comment at: lib/Target/AArch64/AArch64SVEInstrInfo.td:32
+  defm LD1H_D_IMM  : sve_mem_cld_si<0b0111, "ld1h",  Z_d, ZPR64>;
+  defm LD1SH_D_IMM : sve_mem_cld_si<0b1000, "ld1sh", Z_d, ZPR64>;
+  defm LD1SH_S_IMM : sve_mem_cld_si<0b1001, "ld1sh", Z_s, ZPR32>;
----------------
rengolin wrote:
> Nit: keep the same order S/D :)
I actually did this on purpose because the SVE specification orders it by encoding (first column).


https://reviews.llvm.org/D45618





More information about the llvm-commits mailing list