[PATCH] D45535: [DSE] Teach the pass that atomic memory intrinsics are stores.

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 12 23:00:03 PDT 2018


mkazantsev added a comment.

I don't see any problems other than the comment inlined, but I don't know this part of code as well. Please wait for someone more familiar with it to take a look.



================
Comment at: lib/Analysis/MemoryLocation.cpp:88
 
-MemoryLocation MemoryLocation::getForDest(const MemIntrinsic *MTI) {
+MemoryLocation MemoryLocation::getForDest(const MemIntrinsic *MI) {
+  return getForDest(cast<AnyMemIntrinsic>(MI));
----------------
What was the reason of renaming the parameter? Can it go as a separate NFC?


Repository:
  rL LLVM

https://reviews.llvm.org/D45535





More information about the llvm-commits mailing list