[PATCH] D45602: Define InitLLVM to do common initialization all at once.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:81
+int main(int Argc, const char **Argv) {
+  InitLLVM X(Argc, Argv);
 
----------------
stella.stamenova wrote:
> By doing this in this file, ExitOnErr (which is used later in the main function) no longer has the banner set. I suspect the same may be true in some of the other files too. 
> 
> Perhaps InitLLVM could return an ExitOnError object which is already initialized with the correct banner?
Looks like ExitOnError can take a banner as its constructor argument.


https://reviews.llvm.org/D45602