[PATCH] D44184: Write DWARF data into WASM object file

[Yury Delendik via Phabricator via llvm-commits]

yurydelendik marked 3 inline comments as done.
yurydelendik added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:490
+    const auto &FixupSectionName = FixupSection.getSectionName().str();
+    CustomSectionsRelocations[FixupSectionName].push_back(Rec);
+    return;
----------------
sbc100 wrote:
> Could we move this down the end of the function and just have an .isMetadata() before the final else?
> 
> Do we need the above error?
Yes. But I adjusted named symbols check to ignore R_WEBASSEMBLY_*_OFFSET_I32:


Repository:
  rL LLVM

https://reviews.llvm.org/D44184