[PATCH] D45484: [Polly][NewPM] Update pass registration for the LLVM plugin interface

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added inline comments.


================
Comment at: test/lit.site.cfg.in:47-50
     config.substitutions.append(('%loadPolly', '-load '
+                                 + config.polly_lib_dir + '/LLVMPolly at LLVM_SHLIBEXT@'
+                                 + ' -load-pass-plugin '
                                  + config.polly_lib_dir + '/LLVMPolly at LLVM_SHLIBEXT@'
----------------
philip.pfaffe wrote:
> Meinersbur wrote:
> > Don't `-load` and `-load-pass-plugin` conflict? If the so is loaded twice into the address space, shoudn't some global symbols or `cl::opt` initializer clash?
> They don't! That's the beauty of this.
> 
> Both mechanisms are built on top of DynamicLibrary, which guarantees that you can safely load the same shared library twice. 
Cool, I didn't know that.


Repository:
  rPLO Polly

https://reviews.llvm.org/D45484