[PATCH] D45568: [XRay] [compiler-rt] reformat and clarify CMakeLists.txt [NFC]

Martin Pelikán via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 12 06:59:28 PDT 2018


pelikan created this revision.
pelikan added reviewers: dberris, eizan, kpw.
Herald added subscribers: Sanitizers, delcypher, mgorny.

- last change (+ the Apple support change) missed a lot of indentation
- shorten architecture SOURCES definitions as most fit 1 line/arch
- comment in English what's where, and where the different .a come from (using only the word "runtime" in the comment isn't useful, since the CMake primitive itself says "runtime" in its name)
- skip unsupported architectures quickly, to avoid extra indentation


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D45568

Files:
  lib/xray/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45568.142166.patch
Type: text/x-patch
Size: 3884 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180412/9321538a/attachment-0001.bin>


More information about the llvm-commits mailing list