[PATCH] D45213: [COFF][LLD] Add link support for precompiled headers .objs

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 12 06:04:20 PDT 2018


aganea marked an inline comment as done.
aganea added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeStreamMerger.cpp:488
+
+Expected<bool> TypeStreamMerger::shouldRemapType(const CVType &Type) {
+  // For .obj files containing precompiled types, we need to extract the
----------------
aganea wrote:
> I'm not very happy about this - I think I'll move it to lld/COFF/PDB.cpp instead.
After thought, I'll leave it the way it is - I can't find a better way to prevent the LF_ENDPRECOMP from being added to the output TypeTable.


Repository:
  rL LLVM

https://reviews.llvm.org/D45213





More information about the llvm-commits mailing list