[PATCH] D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess()

SAHIL GIRISH YERAWAR via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 12 01:42:36 PDT 2018


cs15btech11044 added inline comments.


================
Comment at: lib/Analysis/ScopInfo.cpp:2308
+
+  if (isl_set_n_basic_set(simple_set.get()) >= MaxDisjunctsInDomain)
+    simple_set = simple_set.simple_hull();
----------------
Meinersbur wrote:
> Consider using `RunTimeChecksMaxAccessDisjuncts` which the current trunk uses.
I do not quite understand why `RunTimeChecksMaxAccessDisjuncts` needs to be used here.

If I remember correctly, the point of this patch was to remove max-disjuncts bailout in `MinMaxAccess` so that the computation limit will decide whether the memory access needs to be considered or not. 
Then why is it being reintroduced here?


Repository:
  rPLO Polly

https://reviews.llvm.org/D45066





More information about the llvm-commits mailing list