[PATCH] D45375: [ELF] - Introduce synthetic file for linker script symbols.

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 11 17:37:54 PDT 2018


espindola added a comment.

In https://reviews.llvm.org/D45375#1065043, @ruiu wrote:

> I'm still in doubt if this is overall a win. At least this patch itself doesn't demonstrate the benefit of having an extra type of file, and I doubt if it will be. Can this simplify things significantly? I think I'm not convinced that we want this one.


I think it can be changed so that we have a reference to a InputFile (or at least know that the pointer is never null).

The reality is that we already have Synthetic files, we just have a very special representation for them: a null pointer.


https://reviews.llvm.org/D45375





More information about the llvm-commits mailing list