[PATCH] D45516: [ELF] - Refactor lazy symbol duplicated code.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Isn't it more complicated than before? I understand that it is tempting, but generally speaking, I try to *not* abstract things unless doing it is a clear win. I'm a bit worried the direction of your recent "refactoring" patches as it adds more abstractions for a (in my opinion) marginal benefits. Factoring out common code is not always a win in terms of readability, especially when it involves callback functions and such. Simple, repeated code is sometimes better, and the original code was written with that in mind. I really prefer boring code over clever code that uses higher order functions.


https://reviews.llvm.org/D45516