[PATCH] D45244: Add missing vtable anchors

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 11 11:42:04 PDT 2018


That sort of surprises me - if that were the case, there would be no point
having LLVMBuild.txt files in any libraries, I would think?

On Wed, Apr 11, 2018 at 10:58 AM Weiming Zhao via Phabricator <
reviews at reviews.llvm.org> wrote:

> weimingz added a comment.
>
> In https://reviews.llvm.org/D45244#1064527, @dblaikie wrote:
>
> > I meant what happens if you remove the changes to tools/lto/LLVMBuild.txt
> >  and tools/llvm-lto/LLVMBuild.txt and /only/ have a change to
> >  lib/LTO/LLVMBuild.txt - is that sufficient to make the build work?
>
>
> I tried before and it didn't work. I think it's because lib/LTO is for the
> generation of libLLVMLTO.a (at least for the default build config), so the
> dependency on MCJIT has no effect on the archive generation.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D45244
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180411/7d7df415/attachment.html>


More information about the llvm-commits mailing list